Bug 27604 - Enable cpplint for .c files
Summary: Enable cpplint for .c files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-23 07:58 PDT by Jakob Petsovits
Modified: 2009-07-23 09:14 PDT (History)
2 users (show)

See Also:

Attachments
Enable cpplint for .c files (6.94 KB, patch)
2009-07-23 08:03 PDT, Jakob Petsovits 		manyoso: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2009-07-23 07:58:02 PDT 
Dave Levin gave ok to relaxing cpplint's filetype filter so that it also does .c files, with Adam Treat stating that it produces reasonable results when testing it on a some of the files.

So here it comes! This patch enables cpplint for .c files, and in turn disables the check for NULL occurrences for .c files (and .m files, to be reasonable safe for the future).
Comment 1 Jakob Petsovits 2009-07-23 08:03:24 PDT 
Created attachment 33329 [details]
Enable cpplint for .c files
Comment 2 Adam Treat 2009-07-23 08:55:22 PDT 
Comment on attachment 33329 [details]
Enable cpplint for .c files

Good stuff, although I think we should remove the .cc file ending as that is not used in WebKit to my knowledge.  Anyways, another patch.
Comment 3 David Levin 2009-07-23 09:07:57 PDT 
Sorry for not mentioning it before, but you may want to also fix this line in check_webkit_style

101	        if file_extension in ['.cc', '.cpp', '.h']:
Comment 4 Adam Treat 2009-07-23 09:14:12 PDT 
Landed with r46269.