WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 27604
Enable cpplint for .c files
https://bugs.webkit.org/show_bug.cgi?id=27604
Summary
Enable cpplint for .c files
Jakob Petsovits
Reported
2009-07-23 07:58:02 PDT
Dave Levin gave ok to relaxing cpplint's filetype filter so that it also does .c files, with Adam Treat stating that it produces reasonable results when testing it on a some of the files. So here it comes! This patch enables cpplint for .c files, and in turn disables the check for NULL occurrences for .c files (and .m files, to be reasonable safe for the future).
Attachments
Enable cpplint for .c files
(6.94 KB, patch)
2009-07-23 08:03 PDT
,
Jakob Petsovits
manyoso
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jakob Petsovits
Comment 1
2009-07-23 08:03:24 PDT
Created
attachment 33329
[details]
Enable cpplint for .c files
Adam Treat
Comment 2
2009-07-23 08:55:22 PDT
Comment on
attachment 33329
[details]
Enable cpplint for .c files Good stuff, although I think we should remove the .cc file ending as that is not used in WebKit to my knowledge. Anyways, another patch.
David Levin
Comment 3
2009-07-23 09:07:57 PDT
Sorry for not mentioning it before, but you may want to also fix this line in check_webkit_style 101 if file_extension in ['.cc', '.cpp', '.h']:
Adam Treat
Comment 4
2009-07-23 09:14:12 PDT
Landed with
r46269
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug