If JIT enabled, the original code works. But if JIT disabled and YARR_JIT enabled only, MacroAssembler.h not included in JIT.h because ENABLE(JIT) macro is false, and it causes build fail.
Created attachment 33321 [details] proposed patch
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JIT.cpp Committed r46334 M JavaScriptCore/jit/JIT.cpp M JavaScriptCore/ChangeLog r46334 = 6a8ef1983c1dbfaebc636ba70a046d28b12b4aab (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46334
Comment on attachment 33321 [details] proposed patch This breaks the build.
bugzilla requires a comment here.
(In reply to comment #3) > This breaks the build. Sorry, it was my fault, because I forgot to delete the last #endif. And during fix it, I found another fix to solve this problem in trunk: http://trac.webkit.org/changeset/46277 I think this fix is not the best solution. You shouldn't include "MacroAssemblerX86Common.h" platform dependent file on all platforms.
Created attachment 33414 [details] proposed patch
Comment on attachment 33414 [details] proposed patch This looks like a reasonable modification to the first patch. Thanks.
I'll try to land this again.
Committing to http://svn.webkit.org/repository/webkit/trunk ... M JavaScriptCore/ChangeLog M JavaScriptCore/jit/JIT.cpp Committed r46347 M JavaScriptCore/jit/JIT.cpp M JavaScriptCore/ChangeLog r46347 = 61403abcd62556810c09bae95594d7bf1cb41deb (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46347