RESOLVED FIXED 275966
[css-writing-modes] Refactor TextFlow to be a struct instead of an enum 
https://bugs.webkit.org/show_bug.cgi?id=275966
Summary [css-writing-modes] Refactor TextFlow to be a struct instead of an enum
Vitor Roriz
Reported 2024-06-27 13:57:37 PDT
TextFlow is currently a enum representing different combinations of TextDirection and BlockFlowDirection (which actually is derived from WritingMode). The enum is a bit confusing to work with, as these names don't make a clear and easy-to-read representation of what they really represent: InlineEastBlockSouth = makeTextFlowInitalizer(BlockFlowDirection::TopToBottom, TextDirection::LTR), InlineWestBlockSouth = makeTextFlowInitalizer(BlockFlowDirection::TopToBottom, TextDirection::RTL), InlineEastBlockNorth = makeTextFlowInitalizer(BlockFlowDirection::BottomToTop, TextDirection::LTR), InlineWestBlockNorth = makeTextFlowInitalizer(BlockFlowDirection::BottomToTop, TextDirection::RTL), InlineSouthBlockEast = makeTextFlowInitalizer(BlockFlowDirection::LeftToRight, TextDirection::LTR), InlineSouthBlockWest = makeTextFlowInitalizer(BlockFlowDirection::LeftToRight, TextDirection::RTL), InlineNorthBlockEast = makeTextFlowInitalizer(BlockFlowDirection::RightToLeft, TextDirection::LTR), InlineNorthBlockWest = makeTextFlowInitalizer(BlockFlowDirection::RightToLeft, TextDirection::RTL) This was discussed here: https://github.com/WebKit/WebKit/pull/30158
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2024-06-28 17:19:24 PDT
<rdar://problem/130787071>
Tim Nguyen (:ntim)
Comment 2 2024-06-28 17:48:13 PDT
Pull request: https://github.com/WebKit/WebKit/pull/30295
EWS
Comment 3 2024-06-28 23:46:54 PDT
Committed 280494@main (a760ea6009c1): <https://commits.webkit.org/280494@main> Reviewed commits have been landed. Closing PR #30295 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.