Bug 275941 - Add Quirks for skype on iPadMini so the content is fully accessible
Summary: Add Quirks for skype on iPadMini so the content is fully accessible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Karl Dubost
URL: https://www.skype.com/en/free-confere...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-06-26 22:59 PDT by Karl Dubost
Modified: 2024-07-30 17:49 PDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karl Dubost 2024-06-26 22:59:49 PDT
There is an issue with free skype calls on iPad Mini, where the UI is not fully visible.

With an iPad Mini, in landscape position:

Steps to reproduce:
1. In landscape, navigate to https://www.skype.com/en/free-conference-call/?cm_mmc=accessurl
2. Tap Create a free video call
3. Tap Start call
4. Tap Allow
5. Observe webpage is cut off

One way to solve it is to apply this rule.

This will make the UI scrollable, and usable.
document.querySelector('.app-container .noFocusOutline > div').style.overflowY = 'scroll’
Comment 1 Karl Dubost 2024-06-26 23:00:21 PDT
<rdar://129048863>
Comment 2 Karl Dubost 2024-06-26 23:11:48 PDT
A quirk might be doable in the case of iPads using similar Quirks than 

void Adjuster::adjustForSiteSpecificQuirks(RenderStyle& style) const {}
https://searchfox.org/wubkat/rev/3402d3c3b3ae0bab3996518d8be3c5d26fb53b16/Source/WebCore/style/StyleAdjuster.cpp#920-974


It needs to be applied to the domain web.skype.com
and with this rule.
document.querySelector('.app-container .noFocusOutline > div').style.overflowY = 'scroll’

Something along with the right list of rules 


if (m_document.quirks().needsIPadSkypeOverflowScrollQuirk()) {
    // list of rules to target the right element.
    // .app-container .noFocusOutline > div

    }
Comment 3 Karl Dubost 2024-07-24 18:52:51 PDT
Pull request: https://github.com/WebKit/WebKit/pull/31203
Comment 4 EWS 2024-07-30 17:49:31 PDT
Committed 281621@main (390b5198a596): <https://commits.webkit.org/281621@main>

Reviewed commits have been landed. Closing PR #31203 and removing active labels.