Bug 27594 – Windows needs a better nightly launching mechanism

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Steve Falkenburg]

The current Windows nightlies are cumbersome to install and use.

We should move to a native nightly launcher to simplifiy this.

[Steve Falkenburg]

Created attachment 33313 [details]
Checkpoint of a new native nightly launcher

[Mark Rowe (bdash)]

Comment on attachment 33313 [details]
Checkpoint of a new native nightly launcher

> Index: WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp
> ===================================================================
> --- WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp	(revision 0)
> +++ WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp	(revision 0)
> @@ -0,0 +1,111 @@
> +/*
> + * Copyright (C) 2009 Apple Inc. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1.  Redistributions of source code must retain the above copyright
> + *     notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *     notice, this list of conditions and the following disclaimer in the
> + *     documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *     its contributors may be used to endorse or promote products derived
> + *     from this software without specific prior written permission.

This isn't the license that we typically use on new code.


The copyEnvironmentVariable function isn't used.  Will it be in the future?


> +int APIENTRY _tWinMain(HINSTANCE instance, HINSTANCE, LPTSTR commandLine, int)
> +{
> +    STARTUPINFO startupInfo = {0};
> +    startupInfo.cb = sizeof(startupInfo);
> +    PROCESS_INFORMATION processInfo = {0};

These should be moved closer to where they're used.

> +    // Launch Safari as a child process
> +    CreateProcess(browserExe, commandLine, 0, 0, FALSE, NORMAL_PRIORITY_CLASS | CREATE_UNICODE_ENVIRONMENT, 0, path, &startupInfo, &processInfo);

Do we need some error handling here in case Safari couldn't be launched for some reason?


r=me

[Eric Seidel (no email)]

Comment on attachment 33313 [details]
Checkpoint of a new native nightly launcher

Steve will land this with modifications.  cq- to denote such.

[Eric Seidel (no email)]

As far as I can tell this is still waiting for landing.  No rush, just confirming.

[Eric Seidel (no email)]

Looks like this was landed as r46254.  Back on July 23rd.