Bug 275923 - Remove Quirk shouldDisableWritingSuggestionsByDefault once Gmail adopts the 'writingsuggestions' attribute.
Summary: Remove Quirk shouldDisableWritingSuggestionsByDefault once Gmail adopts the '...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lily Spiniolas
URL: https://mail.google.com/
Keywords: GoodFirstBug, InRadar
Depends on: 275917
Blocks:
  Show dependency tree / graph
 
Reported: 2024-06-26 15:09 PDT by Lily Spiniolas
Modified: 2024-10-28 12:12 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lily Spiniolas 2024-06-26 15:09:32 PDT 
rdar://130624461
Comment 1 Radar WebKit Bug Importer 2024-07-03 15:10:22 PDT Comment hidden (obsolete)
Comment 2 Tim Nguyen (:ntim) 2024-07-03 16:34:34 PDT 
rdar://130624461
Comment 3 Karl Dubost 2024-08-20 19:43:09 PDT 
1. Open Safari
2. Develop → Developer Settings… → Compatibility: Disable Site Specific hacks
3. Go to the website mail.google.com 
4. Create a new mail
5. Write text.

Does it work?

if yes, we can remove the Quirk
it means Google is using 'writingsuggestions' attribute.
Comment 4 Lily Spiniolas 2024-08-20 21:17:05 PDT 
It looks like the 'writingsuggestions' attribute has indeed been adopted. Thank you Karl!
Comment 5 Lily Spiniolas 2024-08-20 21:19:34 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/32507
Comment 6 Lily Spiniolas 2024-08-20 21:38:15 PDT 
I was incorrect- the attribute has not been adopted.
Comment 7 Lily Spiniolas 2024-10-28 11:16:43 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/35802
Comment 8 EWS 2024-10-28 12:12:32 PDT 
Committed 285779@main (7729bfb61789): <https://commits.webkit.org/285779@main>

Reviewed commits have been landed. Closing PR #35802 and removing active labels.