Bug 275890 - REGRESSION(276197@main): [GTK] Whatsapp Web QR code doesn't load
Summary: REGRESSION(276197@main): [GTK] Whatsapp Web QR code doesn't load
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Linux
: P2 Normal
Assignee: Nitin Mahendru
URL:
Keywords: InRadar
: 280582 (view as bug list)
Depends on:
Blocks:
 
Reported: 2024-06-25 22:41 PDT by Haider Salman
Modified: 2024-09-29 12:37 PDT (History)
7 users (show)

See Also:

Attachments
demonstration of the spinner (130.48 KB, video/webm)
2024-06-25 22:41 PDT, Haider Salman 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Haider Salman 2024-06-25 22:41:59 PDT 
Created attachment 471746 [details]
demonstration of the spinner

When not logged into web.whatsapp.com the QR code which is supposed to appear on the site doesnt load and instead displays a spinner 

this issue was fixed before [here](https://bugs.webkit.org/show_bug.cgi?id=203404) but it has reappeared with the reason not being the same so I opened this new bug report
Comment 1 Haider Salman 2024-06-25 22:44:09 PDT 
Michael Catanzaro I tried it with regular epiphany which is webkitgtk version 2.44.2 and the QR code works fine there
Comment 2 Michael Catanzaro 2024-06-26 05:54:00 PDT 
OK, I can reproduce.

(In reply to Haider Salman from comment #1)
> Michael Catanzaro I tried it with regular epiphany which is webkitgtk
> version 2.44.2 and the QR code works fine there

Great, that's important information. Now I can attempt to bisect it, so it's drastically more likely to be fixed.
Comment 3 Haider Salman 2024-06-26 07:45:01 PDT 
thats great to hear good luck 👍
Comment 4 Michael Catanzaro 2024-06-26 14:47:56 PDT 
This broke in 276197@main "Adding layout tests for postMessage CryptoKey for ServiceWorkers" which has a misleading commit message
Comment 5 Michael Catanzaro 2024-06-26 14:55:22 PDT 
Guess: maybe the default key doesn't work anymore?

What is this master key? Why would an application want to override it? Do we need to expose API to allow applications to configure it? Surely WebCrypto is not just expected to fail by default now?
Comment 6 Michael Catanzaro 2024-09-24 07:46:19 PDT 
So if this is preventing users from logging into WhatsApp, we should revert it now and ask questions later. Too bad I didn't do that in June, when it would have been easier, because there are conflicts. I don't care enough about WhatsApps to sort through this myself; anybody else should feel free.
Comment 7 Nitin Mahendru 2024-09-26 23:30:41 PDT 
<rdar://problem/136807212>
Comment 8 Nitin Mahendru 2024-09-26 23:31:26 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/34348
Comment 9 Nitin Mahendru 2024-09-27 08:26:52 PDT 
Is it possible to verify that your problem is solved with this patch ? IIUC it should.
@Michael, @Haider ?
Comment 10 Michael Catanzaro 2024-09-27 08:38:08 PDT 
I'll test soon.
Comment 11 Michael Catanzaro 2024-09-27 10:28:04 PDT 
(In reply to Nitin Mahendru from comment #9)
> Is it possible to verify that your problem is solved with this patch ? IIUC
> it should.
> @Michael, @Haider ?

Confirmed, your patch works. Thanks!
Comment 12 EWS 2024-09-27 11:56:41 PDT 
Committed 284377@main (0a79bb9adb4c): <https://commits.webkit.org/284377@main>

Reviewed commits have been landed. Closing PR #34348 and removing active labels.
Comment 13 Adrian Perez 2024-09-29 12:37:37 PDT 
*** Bug 280582 has been marked as a duplicate of this bug. ***