Bug 275833 – Sync `RTCCodecStats` from web-specification

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebRTC

[Ahmad Saleem]

Hi Team,

Just looking into WebRTC specific failure for WebKit / Safari, I noticed that we don't match following:

Web-Spec: https://w3c.github.io/webrtc-stats/#codec-dict*

Current WebKit: https://searchfox.org/wubkat/rev/38fb2ecadd89df8d6d7114cc2b030188d744aeb0/Source/WebCore/Modules/mediastream/RTCStatsReport.idl#210


] dictionary RTCCodecStats : RTCStats {
    unsigned long payloadType;
    DOMString transportId;
    DOMString mimeType;
    unsigned long clockRate;
    unsigned long channels;
    DOMString sdpFmtpLine;
};

to:

dictionary RTCCodecStats : RTCStats {
             required unsigned long payloadType;
             required DOMString     transportId;
             required DOMString     mimeType;
             unsigned long clockRate;
             unsigned long channels;
             DOMString     sdpFmtpLine;
};

It is missing 'required', while for 'payloadType', we need to do following change in .h, file here as well: https://searchfox.org/wubkat/rev/38fb2ecadd89df8d6d7114cc2b030188d744aeb0/Source/WebCore/Modules/mediastream/RTCStatsReport.h#400

Change: std::optional<uint32_t> payloadType; to uint32_t payloadType;

___

It compiles with above changes (required and equivalent in '.h' for payloadType).

Just wanted to raise so we can fix it.

Thanks!

[Ahmad Saleem]

*** This bug has been marked as a duplicate of bug 274026 ***