RESOLVED FIXED 275795
Split makeString() and friends out into their own header 
https://bugs.webkit.org/show_bug.cgi?id=275795
Summary Split makeString() and friends out into their own header
Sam Weinig
Reported 2024-06-23 10:50:09 PDT
Split makeString() and friends out into their own header. This is a prerequisite for adding support for for inverleave to makeString, since it will have to depend on StringBuilder, which would cause a cycle otherwise.
Attachments
Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2024-06-23 11:54:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/30097
Radar WebKit Bug Importer
Comment 2 2024-06-30 10:51:12 PDT
<rdar://problem/130853488>
EWS
Comment 3 2024-07-02 12:05:51 PDT
Committed 280586@main (632f10381f7b): <https://commits.webkit.org/280586@main> Reviewed commits have been landed. Closing PR #30097 and removing active labels.
Diego Pino
Comment 4 2024-07-02 16:57:13 PDT
Bot 'WPE-Linux-64-bit-Debug-Build' is failing after this change with the following build error: https://build.webkit.org/#/builders/66/builds/32912 ``` /app/webkit/Source/WebCore/PAL/pal/unix/LoggingUnix.cpp:45:16: error: ‘makeString’ was not declared in this scope 45 | return makeString("NotYetImplemented,"_s, span(logEnv)); | ^~~~~~~~~~ ```
Diego Pino
Comment 5 2024-07-02 16:59:17 PDT
Re-opening for pull request https://github.com/webkit/webkit/pull/30420
EWS
Comment 6 2024-07-02 17:21:36 PDT
Committed 280602@main (4c22854bbd8d): <https://commits.webkit.org/280602@main> Reviewed commits have been landed. Closing PR #30420 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.