Bug 27571 – [CSS3 Backgrounds and Borders] Add support for the "round" value for background-repeat

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Dave Hyatt]

background-repeat now takes a "round" value that allows you to precisely fit tiles.

[Beth Dakin]

Created attachment 38397 [details]
Patch for the CSS part of round and space

Here is a patch for the CSS part of this task. Dan will take on the rendering side later.

Comment on attachment 38397 [details]
Patch for the CSS part of round and space

This patch makes EFillRepeat values require 3 bits, but does not update the size of the m_repeat member of FillLayer, so assigning to it will clobber the m_composite member. Thus I’m r-’ing.

Given bug 28635, I think it will no longer make sense to capture all 16 possible combinations of no-repeat/repeat/space/round with one enum. Instead, I think you should split m_repeat into two fields, one for horizontal repeat and one for vertical repeat. Perhaps you should fix bug 28635 first. Then adding space/round will be simple again (as simple as this patch).

[Beth Dakin]

Created attachment 38409 [details]
Updated patch

Here is a new patch that fixes the bit field issue in FillLayer.h.

Since this patch is ready to go, I would really rather commit it now than wait until after I fix the 2-keywords bug only to rewrite this patch. That one is next though!

[Beth Dakin]

Thanks Dan! Committed r47648.