Bug 275690 – [WPE][GTK] IPC socket should use SOCK_CLOEXEC on Linux

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Instead of creating the IPC socket without CLOEXEC and then setting it afterwards if requested, instead create the socket with CLOEXEC and unset it afterwards if not requested. This closes the race window where the socket may leak into a subprocess spawned by another thread (which seems unlikely, but you never know what applications will do).

There is still a race if using a custom WPE backend with the libwpe process launching API (which is inadvisable, because this means no sandbox).

[Michael Catanzaro]

(In reply to Michael Catanzaro from comment #0)
> There is still a race if using a custom WPE backend with the libwpe process
> launching API (which is inadvisable, because this means no sandbox).

Actually, the race is there for the client socket always regardless. But that's unavoidable since the client socket needs to be leaked to the subprocess.

[Michael Catanzaro]

https://github.com/WebKit/WebKit/pull/30005

[EWS]

Committed 280858@main (23af623a3a7e): <https://commits.webkit.org/280858@main>

Reviewed commits have been landed. Closing PR #30005 and removing active labels.