Bug 275657 - [GStreamer] Error building with libwebrtc enabled with gstreamer 1.18
Summary: [GStreamer] Error building with libwebrtc enabled with gstreamer 1.18
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-19 01:03 PDT by Miguel Gomez
Modified: 2024-06-21 05:20 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2024-06-19 01:03:46 PDT 
According to the GStreamer checks, the required GStreamer version is 1.18.4 (with 1.20 for USE_GSTREAMER_WEBRTC, ENABLE_MEDIA_RECORDER and USE_GSTREAMER_TRANSCODER). But the build enabling libwebrtc fails due to the usage of gst_buffer_new_memdup in Source/WebCore/platform/mediastream/libwebrtc/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp, which is not available on 1.18.
Comment 1 Philippe Normand 2024-06-19 01:59:53 PDT 
in downstream wpe-2.38 this is fixed by commit 5f7400aee390ab9d964a0f2ede34f2008e75eaf8
Comment 2 Miguel Gomez 2024-06-19 02:07:04 PDT 
(In reply to Philippe Normand from comment #1)
> in downstream wpe-2.38 this is fixed by commit
> 5f7400aee390ab9d964a0f2ede34f2008e75eaf8

Shouldn't this upstreamed? Or are we keeping this downstream?
Comment 3 Philippe Normand 2024-06-19 05:06:02 PDT 
It's fine to upstream...

Wasn't needed until now because the SDK ships a recent version, and I suppose you're not using it.
Comment 4 Philippe Normand 2024-06-19 05:20:40 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29979
Comment 5 EWS 2024-06-21 05:20:34 PDT 
Committed 280247@main (1b86aba5013c): <https://commits.webkit.org/280247@main>

Reviewed commits have been landed. Closing PR #29979 and removing active labels.