RESOLVED FIXED 27563
Remove unneeded virtual destructor from ScriptSourceProvider 
https://bugs.webkit.org/show_bug.cgi?id=27563
Summary Remove unneeded virtual destructor from ScriptSourceProvider
Adam Barth
Reported 2009-07-22 14:27:15 PDT
As requested by ap.
Attachments
patch (1020 bytes, patch)
2009-07-22 14:28 PDT, Adam Barth 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2009-07-22 14:28:50 PDT
Created attachment 33289 [details] patch
Alexey Proskuryakov
Comment 2 2009-07-22 16:13:34 PDT
Comment on attachment 33289 [details] patch I actually liked making it non-inline more, but this class isn't used all that much for it to matter. r=me
Adam Barth
Comment 3 2009-07-22 19:52:32 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/js/ScriptSourceProvider.h Committed r46253 M LayoutTests/platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt M LayoutTests/platform/win/fast/css/getComputedStyle/computed-style-expected.txt M LayoutTests/ChangeLog r46252 = 885c66aa16b9d888b2fae5e852b8f14f3773fb26 (trunk) M WebCore/ChangeLog M WebCore/bindings/js/ScriptSourceProvider.h r46253 = 95b02cfaa936edd9f79ab13700bbc2a32819544b (trunk) First, rewinding head to replay your work on top of it... Nothing to do. http://trac.webkit.org/changeset/46253
Note You need to log in before you can comment on or make changes to this bug.