Bug 275611 - REGRESSION(280453@main): [GTK][WPE] Build broken with MEDIA_STREAM disabled
Summary: REGRESSION(280453@main): [GTK][WPE] Build broken with MEDIA_STREAM disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-18 07:42 PDT by Miguel Gomez
Modified: 2024-06-28 08:16 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2024-06-18 07:42:18 PDT 
When MEDIA_STREAM is disabled, the preferences MediaStreamEnabled and MockCaptureDevicesEnabled are not defined, which triggers a build error when calling the FEATURE_DEFAULT macro.
Comment 1 Miguel Gomez 2024-06-25 02:23:29 PDT 
280080@main was reverted by https://commits.webkit.org/280276@main, so this is not happening anymore. Closing.
Comment 2 Miguel Gomez 2024-06-28 05:06:25 PDT 
A variant of the initial PR was merged as 280453@main that has the same problem, so reopening this and setting the new regression revision.
Comment 3 Philippe Normand 2024-06-28 06:23:35 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30268
Comment 4 EWS 2024-06-28 08:16:28 PDT 
Committed 280454@main (22714bafb93d): <https://commits.webkit.org/280454@main>

Reviewed commits have been landed. Closing PR #30268 and removing active labels.