WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
275575
Make WeakPtr to Nodes thread safe again
https://bugs.webkit.org/show_bug.cgi?id=275575
Summary
Make WeakPtr to Nodes thread safe again
Chris Dumez
Reported
2024-06-17 11:21:33 PDT
Make WeakPtr to Nodes thread safe again. This shows as performance neutral on the benchmarks we track. The idea was to make the WeakPtrImpl ref count thread safe so that it we could use WeakPtr<Node> in more places, where performance is critical. However, this didn't work out and we plan to use CheckedPtr<Node> for those cases instead.
Attachments
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2024-06-17 11:24:06 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/29903
EWS
Comment 2
2024-06-17 16:26:59 PDT
Committed
280097@main
(1c010c13ad37): <
https://commits.webkit.org/280097@main
> Reviewed commits have been landed. Closing PR #29903 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-06-17 16:27:15 PDT
<
rdar://problem/130036850
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug