WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
275531
[results.webkit.org] ⌘F should not override system find-in-page if the search panel is collapsed
https://bugs.webkit.org/show_bug.cgi?id=275531
Summary
[results.webkit.org] ⌘F should not override system find-in-page if the search...
Wenson Hsieh
Reported
2024-06-15 12:39:43 PDT
It's sometimes useful to have the ability to invoke system find-in-page to quickly reveal text on the page (like certain build trains). However, even when the search panel is collapsed (and the search input is disabled), ⌘F still attempts to focus the disabled commit search field while overriding the built-in find-in-page functionality. It would be a bit better to defer to the system in this case, so that when the commit search panel is collapsed, the user is able to find text on the page.
Attachments
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2024-06-15 12:44:13 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/29860
EWS
Comment 2
2024-06-17 15:48:39 PDT
Committed
280092@main
(3fecce8a9b38): <
https://commits.webkit.org/280092@main
> Reviewed commits have been landed. Closing PR #29860 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-06-17 15:49:16 PDT
<
rdar://problem/130034672
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug