WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 27553
Fix cpplint generating false positives for "primary" includes in headers
https://bugs.webkit.org/show_bug.cgi?id=27553
Summary
Fix cpplint generating false positives for "primary" includes in headers
Jakob Petsovits
Reported
2009-07-22 12:32:26 PDT
The following piece of code placed in a header file will incorrectly throw an error: (in "FooBar.h":) #include "Foo.h" Which is because Foo.h is classified as primary include, and thus considered the same by the don't-include-yourself check for header files. That's a false positive, and should be fixed. Patch follows below!
Attachments
Fix cpplint generating false positives for "primary" includes in headers
(3.29 KB, patch)
2009-07-22 12:44 PDT
,
Jakob Petsovits
manyoso
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Jakob Petsovits
Comment 1
2009-07-22 12:44:41 PDT
Created
attachment 33283
[details]
Fix cpplint generating false positives for "primary" includes in headers
Adam Treat
Comment 2
2009-07-22 12:51:58 PDT
Landed with
r46231
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug