Bug 275492 - [macOS] Adding writing suggestions to a grid/flex container temporarily creates a block-level inline box
Summary: [macOS] Adding writing suggestions to a grid/flex container temporarily creat...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-06-14 09:41 PDT by Wenson Hsieh
Modified: 2024-06-17 14:04 PDT (History)
11 users (show)

See Also:

Attachments
[fast-cq]Patch (2.25 KB, patch)
2024-06-17 11:41 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2024-06-14 09:41:35 PDT 
Alan noticed that writing suggestions can potentially leave the render tree in a temporary broken state:

```
B---YGLSC-- -+  RenderView at (0,0) size 858x1301 renderer (0x142002d00) layout box (0x0) layout->[normal child] layout id->[20]
B-----LS--- -+    HTML RenderBlock at (0,0) size 858x118 renderer (0x142001810) layout box (0x0) node (0x142001080) layout->[normal child] layout id->[20]
B---------- -+      BODY RenderBody at (8,8) size 842x102 renderer (0x142001b00) layout box (0x0) node (0x142001280) (layout overflow 0,0 842x102) (visual overflow -7,-7 849x116) layout->[normal child] layout id->[20]
B---------- -+*       DIV RenderGrid at (0,0) size 0x0 renderer (0x1420040b0) layout box (0x0) node (0x142003e00) layout->[self][normal child] layout id->[0]
B---YG----- -+          RenderBlock at (0,0) size 0x0 renderer (0x142007b30) layout box (0x0) layout->[self][normal child] layout id->[0]
I---------- -+            #text RenderText renderer (0x142006a50) layout box (0x0) node (0x142003f70) length->(12) "I want to ce" layout->[self] layout id->[n/a]
B---YG----- -+          RenderInline (::-internal-writing-suggestions) renderer (0x142007950) layout box (0x0) layout->[self][normal child] layout id->[0]
I---YG----- -+            RenderText (::-internal-writing-suggestions) renderer (0x142007a60) layout box (0x0) length->(7) "lebrate" layout->[self] layout id->[n/a]
```
Comment 2 zalan 2024-06-17 11:41:32 PDT 
Created attachment 471695 [details]
[fast-cq]Patch
Comment 3 EWS 2024-06-17 13:56:02 PDT 
Committed 280086@main (a88244b5498e): <https://commits.webkit.org/280086@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471695 [details].
Comment 4 Radar WebKit Bug Importer 2024-06-17 13:57:12 PDT 
<rdar://problem/130027859>