WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
275393
[browserperfdash-benchmark] Support using a streaming http response when receiving the status update from the remote dashboard
https://bugs.webkit.org/show_bug.cgi?id=275393
Summary
[browserperfdash-benchmark] Support using a streaming http response when rece...
Carlos Alberto Lopez Perez
Reported
2024-06-12 02:59:21 PDT
When the runner for run-benchmark sends the results to the remote dasboard for processing it waits a reply from it saying if the update of the data was sucessful or not. The issue is that the dashboard does some calculations with this data when receives it, like calculating diff deltas with the previous results and for some benchmarks (like stylebench) this calculations take around 10 minutes. This causes that the connection is dropped on the intermediate firewalls or NATs due to timeout (usually more than 300 seconds without sending anything). To workaround this issue the dashboard now uses a StreamingHttpResponse and each second it sends a dot (".") indicating that the processing is ongoing.
https://github.com/Igalia/browserperfdash/commit/0193bf592b92e8ad641ca79b71e10806aeb1cce5
However the worker now needs to understand this new way of communicating the status from the dashboard. Let's implement it.
Attachments
Add attachment
proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1
2024-06-12 03:26:36 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/29742
EWS
Comment 2
2024-06-20 03:40:09 PDT
Committed
280196@main
(7cc16166ce74): <
https://commits.webkit.org/280196@main
> Reviewed commits have been landed. Closing PR #29742 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug