RESOLVED FIXED275374
Crash under WebKit::WebExtensionContext::didMoveTab 
https://bugs.webkit.org/show_bug.cgi?id=275374
Summary Crash under WebKit::WebExtensionContext::didMoveTab
Timothy Hatcher
Reported 2024-06-11 14:47:39 PDT
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x1b9b5c120 WTF::IdentifiedBase<WTF::ObjectIdentifierGeneric<WebKit::WebExtensionWindowIdentifierType, WTF::ObjectIdentifierMainThreadAccessTraits<unsigned long long>, unsigned long long>>::identifier() const + 0 (/AppleInternal/Library/BuildRoots/a966d782-2437-11ef-a4de-e2437461156c/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.0.Internal.sdk/usr/local/include/wtf/Identified.h:35) [inlined] 1 com.apple.WebKit 0x1b9b5c120 WebKit::WebExtensionContext::didMoveTab(WebKit::WebExtensionTab&, unsigned long, WebKit::WebExtensionWindow const*) + 536 (/AppleInternal/Library/BuildRoots/a966d782-2437-11ef-a4de-e2437461156c/Library/Caches/com.apple.xbs/Sources/WebKit/Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:2262) 2 com.apple.WebKit 0x1b8f00ef0 -[_WKWebExtensionContext didMoveTab:fromIndex:inWindow:] + 196 (/AppleInternal/Library/BuildRoots/a966d782-2437-11ef-a4de-e2437461156c/Library/Caches/com.apple.xbs/Sources/WebKit/Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm:774) 3 com.apple.WebKit 0x1b8f04f68 -[_WKWebExtensionController didMoveTab:fromIndex:inWindow:] + 204 (/AppleInternal/Library/BuildRoots/a966d782-2437-11ef-a4de-e2437461156c/Library/Caches/com.apple.xbs/Sources/WebKit/Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionController.mm:248) 4 com.apple.Safari.Shared.UI 0x1d38b4020 -[WBSWebExtensionsController didMoveTab:fromWindowWithID:indexInOldWindow:] + 132 (/AppleInternal/Library/BuildRoots/a966d782-2437-11ef-a4de-e2437461156c/Library/Caches/com.apple.xbs/Sources/SafariShared/SafariShared/Extensions/WBSWebExtensionsController.mm:5692) 5 com.apple.Safari.framework 0x1c478fddc -[BrowserWindowController _createAndSetupTabWithTabGroupTab:atIndex:] + 812 (/AppleInternal/Library/BuildRoots/a966d782-2437-11ef-a4de-e2437461156c/Library/Caches/com.apple.xbs/Sources/Safari/Mac/Safari/Basics/BrowserWindowController.mm:22323) 6 com.apple.Safari.framework 0x1c47935d4 __75-[BrowserWindowController tabGroupManager:didUpdateTabsInTabGroupWithUUID:]_block_invoke + 244 (/AppleInternal/Library/BuildRoots/a966d782-2437-11ef-a4de-e2437461156c/Library/Caches/com.apple.xbs/Sources/Safari/Mac/Safari/Basics/BrowserWindowController.mm:22880) rdar://129507386
Attachments
Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2024-06-11 14:53:30 PDT
Pull request: https://github.com/WebKit/WebKit/pull/29726
EWS
Comment 2 2024-06-11 15:18:43 PDT
Committed 279928@main (2234ec7559e0): <https://commits.webkit.org/279928@main> Reviewed commits have been landed. Closing PR #29726 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.