WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
275370
[commits.webkit.org] Correctly classify origin commits in hook
https://bugs.webkit.org/show_bug.cgi?id=275370
Summary
[commits.webkit.org] Correctly classify origin commits in hook
Jonathan Bedard
Reported
2024-06-11 13:30:34 PDT
On commits.webkit.org, commits from origin aren't correctly classified because the origin push remote is INVALID. This is a non-standard setup because we don't want commits.webkit.org to be able to push content. This ends up classifying all commits from github.com/WebKit/WebKit as "secure" in our pre-push hook, which isn't correct.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-06-11 13:30:48 PDT
<
rdar://problem/129617235
>
Jonathan Bedard
Comment 2
2024-06-11 13:33:40 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/29722
EWS
Comment 3
2024-06-11 13:42:59 PDT
Committed
279923@main
(149ccc3d4b3c): <
https://commits.webkit.org/279923@main
> Reviewed commits have been landed. Closing PR #29722 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug