Bug 27534 - [QT] make test LayoutTests/fast/block/float/009.html to pass.
Summary: [QT] make test LayoutTests/fast/block/float/009.html to pass.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 26886
  Show dependency tree / graph
 
Reported: 2009-07-22 01:36 PDT by Renata Hodovan
Modified: 2010-03-11 02:22 PST (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Renata Hodovan 2009-07-22 01:36:24 PDT 
The layout test LayoutTests/fast/block/float/009.html fails in the case when the width of a div is given in em. In this case, the width is calculated using defaultFontSize. This variable is set up first in qwebsettings.cpp to 14, then in DumprenderTree.cpp to 13. That's why 10em results in 130px instead of 140px. If we set back the value of defaultFontSize in DRT from 13 to 14, the test succeeds. Alternally, we could have a qt-specific result for this test. Also I have to mention that it's related to the missing proper implementation of unitsPerEm() in the qt font.
Comment 1 Kenneth Rohde Christiansen 2009-10-04 07:52:09 PDT 
Maybe it would be good to fix this in Qt before the 4.6 release? Do you think it should be hard to fix?
Comment 2 Kent Hansen 2010-03-11 02:22:47 PST 
Committed r46974: <http://trac.webkit.org/changeset/46974>