Bug 275290 - neowin.net: 'share' drop-down layout is broken and overlaps
Summary: neowin.net: 'share' drop-down layout is broken and overlaps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-06-08 06:53 PDT by Ahmad Saleem
Modified: 2024-06-09 11:17 PDT (History)
5 users (show)

See Also:


Attachments
Test reduction (431 bytes, text/html)
2024-06-08 09:19 PDT, zalan
no flags Details
Patch (8.11 KB, patch)
2024-06-08 14:42 PDT, zalan
no flags Details | Formatted Diff | Diff
screenshot with fix applied (265.03 KB, image/png)
2024-06-08 14:42 PDT, zalan
no flags Details
[fast-cq]Patch (10.82 KB, patch)
2024-06-08 21:18 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2024-06-08 06:53:29 PDT
Hi Team,

While going through neowin.net website, I found another bug.

Website: https://www.neowin.net/

Steps to Reproduce:

1) Go to website
2) In top sticky bar - go to share button (next to theme toggler)
3) Hover on it to show drop-down

Expected Results:

All social media icons / pics are aligned

Actual Result:

Social media icons are not aligned in STP196

Thanks!
Comment 1 Radar WebKit Bug Importer 2024-06-08 06:54:00 PDT
<rdar://problem/129445546>
Comment 2 zalan 2024-06-08 09:19:43 PDT
Created attachment 471626 [details]
Test reduction

this looks like a float bug where we don't take margin into account when checking for overlap.
Comment 3 zalan 2024-06-08 10:36:10 PDT
> this looks like a float bug where we don't take margin into account when
> checking for overlap.
nope (still a float bug) but the issue here is that we don't let the float overflow its containing block when other float is present even though that other float is not intrusive.
Comment 4 zalan 2024-06-08 14:42:18 PDT
Created attachment 471627 [details]
Patch
Comment 5 zalan 2024-06-08 14:42:57 PDT
Created attachment 471628 [details]
screenshot with fix applied
Comment 6 zalan 2024-06-08 14:43:41 PDT
(let's see if EWS disagrees. will add test case later.)
Comment 7 Ahmad Saleem 2024-06-08 15:17:21 PDT
(In reply to zalan from comment #6)
> (let's see if EWS disagrees. will add test case later.)

Awesome! Thanks Alan for tackling this quickly. :)
Comment 8 zalan 2024-06-08 15:47:58 PDT
(In reply to Ahmad Saleem from comment #7)
> (In reply to zalan from comment #6)
> > (let's see if EWS disagrees. will add test case later.)
> 
> Awesome! Thanks Alan for tackling this quickly. :)
Thanks for reporting it (apparently it needs a bit more work though)
Comment 9 zalan 2024-06-08 21:18:52 PDT
Created attachment 471629 [details]
[fast-cq]Patch
Comment 10 EWS 2024-06-09 11:17:36 PDT
Committed 279867@main (b424c89ef690): <https://commits.webkit.org/279867@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471629 [details].