Bug 275290 – neowin.net: 'share' drop-down layout is broken and overlaps

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ahmad Saleem]

Hi Team,

While going through neowin.net website, I found another bug.

Website: https://www.neowin.net/

Steps to Reproduce:

1) Go to website
2) In top sticky bar - go to share button (next to theme toggler)
3) Hover on it to show drop-down

Expected Results:

All social media icons / pics are aligned

Actual Result:

Social media icons are not aligned in STP196

Thanks!

[Radar WebKit Bug Importer]

<rdar://problem/129445546>

[alan]

Created attachment 471626 [details]
Test reduction

this looks like a float bug where we don't take margin into account when checking for overlap.

[alan]

> this looks like a float bug where we don't take margin into account when
> checking for overlap.
nope (still a float bug) but the issue here is that we don't let the float overflow its containing block when other float is present even though that other float is not intrusive.

[alan]

Created attachment 471627 [details]
Patch

[alan]

Created attachment 471628 [details]
screenshot with fix applied

[alan]

(let's see if EWS disagrees. will add test case later.)

[Ahmad Saleem]

(In reply to zalan from comment #6)
> (let's see if EWS disagrees. will add test case later.)

Awesome! Thanks Alan for tackling this quickly. :)

[alan]

(In reply to Ahmad Saleem from comment #7)
> (In reply to zalan from comment #6)
> > (let's see if EWS disagrees. will add test case later.)
> 
> Awesome! Thanks Alan for tackling this quickly. :)
Thanks for reporting it (apparently it needs a bit more work though)

[alan]

Created attachment 471629 [details]
[fast-cq]Patch

[EWS]

Committed 279867@main (b424c89ef690): <https://commits.webkit.org/279867@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471629 [details].