Bug 27529 - run-webkit-lint checks code which are not changed
Summary: run-webkit-lint checks code which are not changed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: David Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-21 22:50 PDT by Shinichiro Hamaji
Modified: 2009-07-22 15:10 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (1.29 KB, patch)
2009-07-21 22:51 PDT, Shinichiro Hamaji
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-07-21 22:50:22 PDT
The run-webkit-lint checks lines around the modified line.
Comment 1 Shinichiro Hamaji 2009-07-21 22:51:16 PDT
Created attachment 33242 [details]
Patch v1


---
 2 files changed, 15 insertions(+), 1 deletions(-)
Comment 2 David Levin 2009-07-21 23:24:30 PDT
Comment on attachment 33242 [details]
Patch v1


>                  if not line_numbers:
>                      for line in diff.lines:
> -                        line_numbers.add(line[1])
> +                        # When deleted line is not set, it means that
> +                        # the line is newly added.

There is no need to wrap this comment.

> +                        if not line[0]:
> +                            line_numbers.add(line[1])
Of course...nice fix.
Comment 3 David Levin 2009-07-22 14:24:25 PDT
Assign to levin for landing.
Comment 4 David Levin 2009-07-22 15:10:46 PDT
Committed as http://trac.webkit.org/changeset/46243