RESOLVED FIXED 27529
run-webkit-lint checks code which are not changed 
https://bugs.webkit.org/show_bug.cgi?id=27529
Summary run-webkit-lint checks code which are not changed
Shinichiro Hamaji
Reported 2009-07-21 22:50:22 PDT
The run-webkit-lint checks lines around the modified line.
Attachments
Patch v1 (1.29 KB, patch)
2009-07-21 22:51 PDT, Shinichiro Hamaji 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shinichiro Hamaji
Comment 1 2009-07-21 22:51:16 PDT
Created attachment 33242 [details] Patch v1 --- 2 files changed, 15 insertions(+), 1 deletions(-)
David Levin
Comment 2 2009-07-21 23:24:30 PDT
Comment on attachment 33242 [details] Patch v1 > if not line_numbers: > for line in diff.lines: > - line_numbers.add(line[1]) > + # When deleted line is not set, it means that > + # the line is newly added. There is no need to wrap this comment. > + if not line[0]: > + line_numbers.add(line[1]) Of course...nice fix.
David Levin
Comment 3 2009-07-22 14:24:25 PDT
Assign to levin for landing.
David Levin
Comment 4 2009-07-22 15:10:46 PDT
Committed as http://trac.webkit.org/changeset/46243
Note You need to log in before you can comment on or make changes to this bug.