RESOLVED FIXED 275174
The URL for Chromium bugs has changed, stopping them from being added to See Also in Bugzilla
https://bugs.webkit.org/show_bug.cgi?id=275174
Summary The URL for Chromium bugs has changed, stopping them from being added to See ...
Daniel Jacobs
Reported 2024-06-05 11:35:43 PDT
https://bugs.chromium.org/p/chromium/issues/list is now https://issues.chromium.org/issues, but that is not an accepted URL for adding bugs to See Also.
Attachments
Daniel Jacobs
Comment 1 2024-06-05 13:43:48 PDT
Alexey Proskuryakov
Comment 2 2024-06-05 14:07:12 PDT
Thank you for the report! The fix would be in Websites/bugs.webkit.org/Bugzilla/BugUrl/Chromium.pm
Daniel Jacobs
Comment 3 2024-06-05 20:08:36 PDT
Maybe the subroutines in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Chromium.pm should just be these, adapted from the simpler code in https://github.com/WebKit/WebKit/blob/main/Websites/bugs.webkit.org/Bugzilla/BugUrl/Google.pm. Though if there's still a desire to support the old Chromium URL syntax the code would either need to be more complex or these subroutines could be added to a new Perl module. I just don't understand the point of the current code for Chromium that gets $project_name and $bug_id in _check_value. sub should_handle { my ($class, $uri) = @_; # Chromium URLs have this form: # http(s)://issues.chromium.org/issues/1234 return (lc($uri->authority) eq 'issues.chromium.org' and $uri->path =~ m|^/issues/\d+$| ? 1 : 0; } sub _check_value { my ($class, $uri) = @_; $uri = $class->SUPER::_check_value($uri); return $uri; }
Karl Dubost
Comment 4 2024-06-06 22:17:58 PDT
is there a chance that old URI will go 500 in the future or 410 Gone? Asking because I wonder if the bugs should be updated.
Daniel Jacobs
Comment 5 2024-06-07 10:28:28 PDT
EWS
Comment 6 2024-06-09 09:46:44 PDT
Committed 279863@main (15c7ae209695): <https://commits.webkit.org/279863@main> Reviewed commits have been landed. Closing PR #29624 and removing active labels.
Radar WebKit Bug Importer
Comment 7 2024-06-09 09:47:14 PDT
Note You need to log in before you can comment on or make changes to this bug.