Bug 27516 – Add onerror to WorkerContext.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore JavaScript

[Jian Li]

Add onerror to WorkerContext.

[Jian Li]

Created attachment 33214 [details]
Proposed Patch

[Jian Li]

This is to adhere to the latest Web Worker spec (http://www.whatwg.org/specs/web-workers/current-work/#workerglobalscope):
  interface WorkerGlobalScope {
      ...
      attribute Function onerror;
  };

I will have other patches that will trigger onerror.

[David Levin]

Comment on attachment 33214 [details]
Proposed Patch

Just a few things to clean up.


> diff --git a/WebCore/workers/WorkerContext.h b/WebCore/workers/WorkerContext.h

> +        RefPtr<EventListener> m_onErrorListener;

Should be "m_onerrorListener" because onerror seems to consistently treated as one word.



> diff --git a/WebCore/workers/WorkerContext.idl b/WebCore/workers/WorkerContext.idl
>  #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> -                 attribute [Replaceable] WorkerContext self;
> +        attribute [Replaceable] WorkerContext self;

Don't unindent these.  The idl formatting leaves room for "readonly " when it isn't present which is why these are indented to this level.

>  #endif
> -                 attribute [Replaceable] WorkerLocation location;
> +        attribute [Replaceable] WorkerLocation location;

Same unindenting comment.

>          void close();
> -        //         attribute EventListener onerror;
> +        attribute EventListener onerror;

Just uncomment but indent correctly.

[Jian Li]

Created attachment 33218 [details]
Proposed Patch

[Jian Li]

Committed as http://trac.webkit.org/changeset/46197 and http://trac.webkit.org/changeset/46198.