Bug 275153 - Limit the number of repaint candidates after simplified layout
Summary: Limit the number of repaint candidates after simplified layout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-06-05 05:16 PDT by zalan
Modified: 2024-06-07 18:34 PDT (History)
11 users (show)

See Also:

Attachments
Patch (9.27 KB, patch)
2024-06-05 05:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (9.31 KB, patch)
2024-06-05 10:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (12.70 KB, patch)
2024-06-05 15:18 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.47 KB, patch)
2024-06-05 21:14 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (14.97 KB, patch)
2024-06-06 07:33 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (17.37 KB, patch)
2024-06-06 20:39 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (17.37 KB, patch)
2024-06-07 10:22 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (6) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2024-06-05 05:16:22 PDT 
ssia
Comment 1 zalan 2024-06-05 05:19:15 PDT 
Created attachment 471591 [details]
Patch
Comment 2 zalan 2024-06-05 10:22:16 PDT 
Created attachment 471595 [details]
Patch
Comment 3 zalan 2024-06-05 15:18:18 PDT 
Created attachment 471597 [details]
Patch
Comment 4 zalan 2024-06-05 21:14:21 PDT 
Created attachment 471599 [details]
Patch
Comment 5 zalan 2024-06-06 07:33:55 PDT 
Created attachment 471610 [details]
Patch
Comment 6 Simon Fraser (smfr) 2024-06-06 14:11:59 PDT 
Comment on attachment 471610 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471610&action=review

> Source/WebCore/page/LocalFrameViewLayoutContext.h:190
> +    unsigned m_layoutIdentifier : 11 { 0 };

Let's use a type for LayoutIdentifier

> Source/WebCore/rendering/RenderElement.h:409
> +    unsigned m_layoutIdentifier : 11 { 0 };

Maybe we should just eat up 16 or 32 bits (shuffling things around if necessary).

> Source/WebCore/rendering/RenderLayer.cpp:1025
> +            return renderer().layoutIdentifier() == renderer().view().frameView().layoutContext().layoutIdentifier();

Think about putting this in a helper on RenderElement.
Comment 7 zalan 2024-06-06 20:39:45 PDT 
Created attachment 471615 [details]
Patch
Comment 8 zalan 2024-06-07 10:22:48 PDT 
Created attachment 471621 [details]
[fast-cq]Patch
Comment 9 EWS 2024-06-07 18:33:50 PDT 
Committed 279847@main (4a5b56e32671): <https://commits.webkit.org/279847@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 471621 [details].
Comment 10 Radar WebKit Bug Importer 2024-06-07 18:34:15 PDT 
<rdar://problem/129428778>