RESOLVED FIXED275134
Enable GraphicsContext filters for Canvas filter
https://bugs.webkit.org/show_bug.cgi?id=275134
Summary Enable GraphicsContext filters for Canvas filter
Said Abou-Hallawa
Reported 2024-06-04 16:26:24 PDT
GraphicsContext filters were disabled for the canvas filter in 278000@main. The canvas drop-shadow filter was drawn upside down. So software filters were used instead to make the layout test pass. It turned out all we need is to flip the sign of the vertical offset of the drop-shadow. This is what CanvasRenderingContext2DBase::applyShadow() does when it sets GraphicsContext drop-shadow by calling: c->setDropShadow({ { width, -height }, state().shadowBlur, state().shadowColor, ShadowRadiusMode::Legacy });
Attachments
Radar WebKit Bug Importer
Comment 1 2024-06-04 16:26:51 PDT
Said Abou-Hallawa
Comment 2 2024-06-04 16:32:59 PDT
EWS
Comment 3 2024-06-20 02:37:38 PDT
Committed 280195@main (8e66e149a07d): <https://commits.webkit.org/280195@main> Reviewed commits have been landed. Closing PR #29522 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.