WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
275134
Enable GraphicsContext filters for Canvas filter
https://bugs.webkit.org/show_bug.cgi?id=275134
Summary
Enable GraphicsContext filters for Canvas filter
Said Abou-Hallawa
Reported
2024-06-04 16:26:24 PDT
GraphicsContext filters were disabled for the canvas filter in
278000@main
. The canvas drop-shadow filter was drawn upside down. So software filters were used instead to make the layout test pass. It turned out all we need is to flip the sign of the vertical offset of the drop-shadow. This is what CanvasRenderingContext2DBase::applyShadow() does when it sets GraphicsContext drop-shadow by calling: c->setDropShadow({ { width, -height }, state().shadowBlur, state().shadowColor, ShadowRadiusMode::Legacy });
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2024-06-04 16:26:51 PDT
<
rdar://problem/129249264
>
Said Abou-Hallawa
Comment 2
2024-06-04 16:32:59 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/29522
EWS
Comment 3
2024-06-20 02:37:38 PDT
Committed
280195@main
(8e66e149a07d): <
https://commits.webkit.org/280195@main
> Reviewed commits have been landed. Closing PR #29522 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug