RESOLVED FIXED 274969
Two files include <Timer.h> instead of "Timer.h" 
https://bugs.webkit.org/show_bug.cgi?id=274969
Summary Two files include <Timer.h> instead of "Timer.h"
Francisco Tolmasky
Reported 2024-05-31 08:50:34 PDT
Both "WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h" and "WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h" use "#include <Timer.h>" instead of "#include "Timer.h"". They seem to be the only two instances of using <> to do a peer search. As far as I can tell there is no specific reason for this, that is to say, it is not a workaround for finding the wrong Timer.h or something. I have changed them to "Timer.h" and it compiled fine. The current use of "<Timer.h>" is causing issues when I am trying to include these files somewhere else. You get the following error: error: 'Timer.h' file not found with <angled> include; use "quotes" instead 35 | #include <Timer.h> | ^~~~~~~~~ | "Timer.h" If there is no reason for using "Timer.h", can I submit a PR changing to use "Timer.h"?
Attachments
Add attachment proposed patch, testcase, etc.
Ahmad Saleem
Comment 1 2024-05-31 08:56:22 PDT
@Francisco - I think it would be good to submit PR and get feedback. :-)
EWS
Comment 2 2024-06-01 19:46:42 PDT
Committed 279621@main (838cb152e878): <https://commits.webkit.org/279621@main> Reviewed commits have been landed. Closing PR #29376 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-06-01 19:47:16 PDT
<rdar://problem/129119819>
Note You need to log in before you can comment on or make changes to this bug.