Feature request: cpplint should check for indentation - rule 6

[Luciano Wolf]

According to Indentation rule 6 of the Webkit coding style guidelines[1]:
"Boolean expressions at the same nesting level that span multiple lines should have their operators on the left side of the line instead of the right side."

This isn't currently tested by the cpplint.

[1]
http://webkit.org/coding/coding-style.html

[Jakob Petsovits]

Hm... I wonder if there are any cases where "||" and "&&" are allowed at the end of the line? Otherwise, this would be ridiculously easy.

[David Levin]

>  I wonder if there are any cases where "||" and "&&" are allowed at the end of the line? 

No.

[Jakob Petsovits]

Created attachment 33213 [details]
Add checks for multi-line boolean operator placement

...like this? Seems the new check caught an issue in cpplint_unittest.py itself :P

[David Levin]

> Seems the new check caught an issue in cpplint_unittest.py itself

Yeah, this tool was originally developed for Google style which doesn't have this rule, so as it gets closer to WebKit style, differences in WebKit and Google style are exposed (which is all good).

[Adam Treat]

Landed with r46224.