Bug 274914 - Web Inspector: DebuggerManager. _associateBreakpointsWithSourceCode should only allow updates from the main frame
Summary: Web Inspector: DebuggerManager. _associateBreakpointsWithSourceCode should on...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P3 Minor
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-30 11:53 PDT by Qianlang Chen
Modified: 2024-05-30 11:53 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Qianlang Chen 2024-05-30 11:53:10 PDT 
The patch https://github.com/WebKit/WebKit/pull/27000 makes DebuggerManager._associateBreakpointsWithSourceCode always able to update a breakpoint's linked-to source code in order to prevent those source code objects becoming stale when e.g. the page reloads. However, as pointed out [in a code-review comment](https://github.com/WebKit/WebKit/pull/27000/files#r1609384544), this fix might cause issues when there are resources with the same URL/contentIdentifier coming from a sub-frame. Despite that perhaps being quite an unlikely scenario, we should consider improving that resource-updating logic and maybe apply the suggested fix in that comment.
Comment 1 Radar WebKit Bug Importer 2024-05-30 11:53:23 PDT 
<rdar://problem/129018314>
Comment 2 Radar WebKit Bug Importer 2024-05-30 11:53:38 PDT 
<rdar://problem/129018306>