Bug 274894 - [CMake][GLib] Propagate unified build setting to make-dist script
Summary: [CMake][GLib] Propagate unified build setting to make-dist script
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-30 04:02 PDT by Adrian Perez
Modified: 2024-05-30 04:58 PDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2024-05-30 04:02:03 PDT
The Tools/Scripts/make-dist script gained an --unified/-u command line
flag in 272404@main so we could check the value of ENABLE_UNIFIED_BUILDS
and pass it accordingly. Then using build-webkit to generate releases
like this:

  Tools/Scripts/build-webkit --wpe --makeargs=distcheck --no-unified-builds
  Tools/Scripts/build-webkit --wpe --makeargs=distcheck --unified-builds

would also result in doing the build from the generated tarball unified
or not depending on the CMake setting and whether --[no-]unified-builds
was used with build-webkit.

The main motivation for this is that we typically care about non-unified
builds for stable releases, but we may want to skip checking them for
development releases which are cut from the “main” branch (specially when
the build is tricky to fix), and this makes it easier to choose what the
script should do.
Comment 1 Adrian Perez 2024-05-30 04:06:33 PDT
Pull request: https://github.com/WebKit/WebKit/pull/29299
Comment 2 EWS 2024-05-30 04:58:46 PDT
Committed 279509@main (5dfbc67f91ea): <https://commits.webkit.org/279509@main>

Reviewed commits have been landed. Closing PR #29299 and removing active labels.