Bug 27489 - cpplint's parse_argument should not exit even if no files are specified
Summary: cpplint's parse_argument should not exit even if no files are specified
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-21 01:20 PDT by Shinichiro Hamaji
Modified: 2009-07-21 03:07 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (3.25 KB, patch)
2009-07-21 01:22 PDT, Shinichiro Hamaji
levin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Shinichiro Hamaji 2009-07-21 01:20:33 PDT
run-webkit-lint script will use parse_argument() function. As the script will lint the current diff by default, we should not exit even if no files are specified.
Comment 1 Shinichiro Hamaji 2009-07-21 01:22:20 PDT
Created attachment 33156 [details]
Patch v1


---
 3 files changed, 17 insertions(+), 7 deletions(-)
Comment 2 David Levin 2009-07-21 03:07:03 PDT
Committed as http://trac.webkit.org/changeset/46161