STR: ``` import-w3c-tests web-platform-tests/clipboard-apis --src-dir . --clean-dest-dir ``` Where the --src-dir does not contain any wpt tests (any random folder).
Noting that the output form this is: Import complete IMPORTED 0 TOTAL TESTS Imported 0 reftests Imported 0 JS tests Imported 0 Crash tests Imported 0 pixel/manual tests Properties needing prefixes (by count): So, even though it claims nothing happened, it actually trashed an entire directory. That's quite unexpected and could lead to confusion.
<rdar://problem/128981568>
rdar://117683918
Pull request: https://github.com/WebKit/WebKit/pull/29695
The fundamental problem here is we should error out when you request to import a path that doesn't exist (because either the source directory doesn't exist, or the path doesn't exist within the source directory), rather than continuing and importing the zero tests within the non-existent path, and with `--clean-dest-dir` deleting any currently imported tests because those tests don't exist in the non-existent path. That makes the same as rdar://117683918, which wasn't specifically about the `--clean-dest-dir` case, but was about confusion with nothing getting imported when a non-existent path is passed (because it just does nothing at all without `--clean-dest-dir`).
> The fundamental problem here is we should error out when you request to import a path that doesn't exist yes that's the goal.