Bug 274873 - [SHA1] Add fast path when adding UTF8 bytes from a String that only contains ASCII
Summary: [SHA1] Add fast path when adding UTF8 bytes from a String that only contains ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-29 17:11 PDT by Chris Dumez
Modified: 2024-05-30 07:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2024-05-29 17:11:24 PDT 
Add fast path when adding UTF8 bytes from a String that only contains ASCII. Also fix a bug in our HTTP disk cache hashing function where there was already a fast path and this fast path was hashing the null terminator, where was the slow path wasn't. Align both code paths so that we never hash the null terminator and bump the HTTP cache version since this change is not backward compatible.
Comment 1 Chris Dumez 2024-05-29 18:18:38 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29273
Comment 2 EWS 2024-05-30 07:40:24 PDT 
Committed 279513@main (484500b2c078): <https://commits.webkit.org/279513@main>

Reviewed commits have been landed. Closing PR #29273 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-05-30 07:50:29 PDT 
<rdar://problem/129005213>