Bug 274858 - WebCore::ScopedInspectorShaderProgramHighlight constructor does not initialize struct m_savedBlend
Summary: WebCore::ScopedInspectorShaderProgramHighlight constructor does not initializ...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 241463
Blocks:
  Show dependency tree / graph
 
Reported: 2024-05-29 13:37 PDT by David Kilzer (:ddkilzer)
Modified: 2024-05-29 13:41 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2024-05-29 13:37:53 PDT 
WebCore::ScopedInspectorShaderProgramHighlight constructor does not initialize struct m_savedBlend.

Regressed in:

    Fix InspectorScopedShaderProgramHighlight for indexed blend state
    https://bugs.webkit.org/show_bug.cgi?id=241463
    <rdar://problem/95292922>
    <https://commits.webkit.org/251634@main>

```diff
     struct {
-        RefPtr<Float32Array> color;
-        unsigned equationRGB { 0 };
-        unsigned equationAlpha { 0 };
-        unsigned srcRGB { 0 };
-        unsigned srcAlpha { 0 };
-        unsigned dstRGB { 0 };
-        unsigned dstAlpha { 0 };
-        bool enabled { false };
+        GCGLfloat color[4];
+        GCGLenum equationRGB;
+        GCGLenum equationAlpha;
+        GCGLenum srcRGB;
+        GCGLenum dstRGB;
+        GCGLenum srcAlpha;
+        GCGLenum dstAlpha;
+        GCGLboolean enabled;
     } m_savedBlend;
```
Comment 1 Radar WebKit Bug Importer 2024-05-29 13:38:13 PDT 
<rdar://problem/128962006>
Comment 2 David Kilzer (:ddkilzer) 2024-05-29 13:41:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29245