Bug 27485 - Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
Summary: Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-21 00:07 PDT by Gavin Barraclough
Modified: 2009-07-21 17:42 PDT (History)
0 users

See Also:

Attachments
The patch (40.39 KB, patch)
2009-07-21 00:16 PDT, Gavin Barraclough 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2009-07-21 00:07:48 PDT 
Some code that is really related to architecture-specific MacroAssemblers is currently residing in the AbstractMacroAssembler, and in the architecture specific assembler classes.  By moving these classes up the food chain we can then split the implementation methods out to the appropriate MacroAssemblers, to resolve these issues.
Comment 1 Gavin Barraclough 2009-07-21 00:16:28 PDT 
Created attachment 33150 [details]
The patch
Comment 2 Oliver Hunt 2009-07-21 01:35:36 PDT 
Comment on attachment 33150 [details]
The patch

r=me
Comment 3 Gavin Barraclough 2009-07-21 17:42:33 PDT 
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj
Sending        JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
Sending        JavaScriptCore/assembler/ARMAssembler.h
Sending        JavaScriptCore/assembler/ARMv7Assembler.h
Sending        JavaScriptCore/assembler/AbstractMacroAssembler.h
Adding         JavaScriptCore/assembler/LinkBuffer.h
Adding         JavaScriptCore/assembler/RepatchBuffer.h
Sending        JavaScriptCore/assembler/X86Assembler.h
Sending        JavaScriptCore/jit/JIT.cpp
Sending        JavaScriptCore/jit/JITPropertyAccess.cpp
Sending        JavaScriptCore/yarr/RegexJIT.cpp
Transmitting file data ............
Committed revision 46202.