WebKit Bugzilla
New
Browse
Log In
×
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 274844
Need to SUPPRESS_ASAN on MetadataTable::isDestroyed().
https://bugs.webkit.org/show_bug.cgi?id=274844
Summary
Need to SUPPRESS_ASAN on MetadataTable::isDestroyed().
Mark Lam
Reported
2024-05-29 10:11:58 PDT
MetadataTable::isDestroyed() is used to check if the unlinkedMetadata Ref is null as a null check mitigation. Under normal circumstances, when a Ref is leaked and nullified, its memory gets poison on ASAN to ensure that it is not accessed thereafter. This conflicts with out mitigation which wishes to access it after it is nullified. The fix here is simply to apply SUPPRESS_ASAN to MetadataTable::isDestroyed().
rdar://128875400
Attachments
Add attachment
proposed patch, testcase, etc.
Mark Lam
Comment 1
2024-05-29 10:17:41 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/29228
EWS
Comment 2
2024-05-29 11:20:51 PDT
Committed
279451@main
(07e51b93d7e7): <
https://commits.webkit.org/279451@main
> Reviewed commits have been landed. Closing PR #29228 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug