Bug 274804 - [Site Isolation] Back forward items for cross-origin iframe navigations are ignored
Summary: [Site Isolation] Back forward items for cross-origin iframe navigations are i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Process Model (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Wolfe
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-28 15:33 PDT by Charlie Wolfe
Modified: 2024-05-29 18:21 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Wolfe 2024-05-28 15:33:12 PDT 
We should only expect an additional back forward item for the initial load of a root child frame. Separate back forward items are already created when navigating within a child frame (even without site isolation), so we don’t need to set any additional state on those items. This was causing us to skip over cross-origin iframe navigations when moving in the back forward list. Going back/forward to cross-origin iframes still doesn’t work correctly for different reasons.
Comment 1 Radar WebKit Bug Importer 2024-05-28 15:33:22 PDT 
<rdar://problem/128902889>
Comment 2 Charlie Wolfe 2024-05-28 15:35:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29194
Comment 3 EWS 2024-05-29 18:21:41 PDT 
Committed 279486@main (df735d5e5a8a): <https://commits.webkit.org/279486@main>

Reviewed commits have been landed. Closing PR #29194 and removing active labels.