Bug 274762 - Fix render tree construction when inlines are inserted in reverse after a block in a continuation
Summary: Fix render tree construction when inlines are inserted in reverse after a blo...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-27 18:39 PDT by Ahmad Saleem
Modified: 2024-05-28 19:40 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ahmad Saleem 2024-05-27 18:39:49 PDT 
Hi Team,

While going through Blink's commit, I came across another potential merge and failing test case:

Test Case: https://jsfiddle.net/a0txqehw/

Blink Commit: https://chromium.googlesource.com/chromium/blink/+/6ac676e5e68e3271321b9c8236192b6a530d055e

It seems to be fixed, if changed L156 to following in RenderTreeBuilder::Inline::insertChildToContinuation:

if (childInline == beforeChildAncestor->isInline() || (beforeChild && beforeChild->isInline()))

__

Just raising so we can fix it.

Thanks!
Comment 1 Radar WebKit Bug Importer 2024-05-27 18:40:13 PDT 
<rdar://problem/128826228>
Comment 2 Ahmad Saleem 2024-05-27 19:53:33 PDT 
PR - https://github.com/WebKit/WebKit/pull/29162
Comment 3 EWS 2024-05-28 19:40:23 PDT 
Committed 279422@main (4af8f052cd4f): <https://commits.webkit.org/279422@main>

Reviewed commits have been landed. Closing PR #29162 and removing active labels.