Bug 27473 - Chromium Linux: cache Harfbuzz faces
Summary: Chromium Linux: cache Harfbuzz faces
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-20 17:07 PDT by Adam Langley
Modified: 2009-07-20 19:23 PDT (History)
0 users

See Also:


Attachments
patch (5.71 KB, patch)
2009-07-20 17:49 PDT, Adam Langley
no flags Details | Formatted Diff | Diff
patch (5.71 KB, patch)
2009-07-20 19:04 PDT, Adam Langley
no flags Details | Formatted Diff | Diff
patch (8.37 KB, patch)
2009-07-20 19:05 PDT, Adam Langley
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-07-20 17:07:39 PDT
Previously, we recreated the Harfbuzz face for each script-run. With this patch, we keep the Harfbuzz face in the FontPlatformData (created as needed) and so they will persist for the duration of the FontPlatformData.

Shouldn't affect any layout tests.
Comment 1 Adam Langley 2009-07-20 17:49:47 PDT
Created attachment 33128 [details]
patch
Comment 2 Adam Langley 2009-07-20 19:04:07 PDT
Created attachment 33133 [details]
patch
Comment 3 Adam Langley 2009-07-20 19:05:22 PDT
Created attachment 33134 [details]
patch
Comment 4 Eric Seidel (no email) 2009-07-20 19:06:53 PDT
Comment on attachment 33134 [details]
patch

Seems fine.