Bug 27469 - Make it harder to misuse try* allocation routines
Summary: Make it harder to misuse try* allocation routines
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Oliver Hunt
Depends on:
Reported: 2009-07-20 16:32 PDT by Oliver Hunt
Modified: 2009-08-13 14:55 PDT (History)
0 users

See Also:

a patch (22.68 KB, patch)
2009-07-20 17:38 PDT, Oliver Hunt
oliver: review-
Details | Formatted Diff | Diff
a correct patch (22.61 KB, patch)
2009-07-20 17:45 PDT, Oliver Hunt
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2009-07-20 16:32:39 PDT
I'm paranoid so i'd like to make it harder to avoid null checking the results of try* allocation functions.
Comment 1 Oliver Hunt 2009-07-20 17:38:56 PDT
Created attachment 33126 [details]
a patch
Comment 2 Oliver Hunt 2009-07-20 17:39:22 PDT
Comment on attachment 33126 [details]
a patch

whoops, bad patch
Comment 3 Oliver Hunt 2009-07-20 17:45:40 PDT
Created attachment 33127 [details]
a correct patch
Comment 4 Gavin Barraclough 2009-07-20 19:42:04 PDT
Comment on attachment 33127 [details]
a correct patch

Please rename 'Maybe' to 'PossiblyNull', abarth ftw!
Comment 5 Oliver Hunt 2009-07-20 21:36:24 PDT
Fix landed in 46153
Comment 6 Oliver Hunt 2009-08-11 22:26:53 PDT
This was rolled out ue to windows bustage
Comment 7 Eric Seidel (no email) 2009-08-13 14:47:18 PDT
Comment on attachment 33127 [details]
a correct patch

Clearing barraclough's review flag to not confuse us humans.
Comment 8 Oliver Hunt 2009-08-13 14:55:41 PDT
This was relanded in r47092 with appropriate fixes