RESOLVED FIXED274682
Introduce a concrete result type for JSValue -> Implementation conversions
https://bugs.webkit.org/show_bug.cgi?id=274682
Summary Introduce a concrete result type for JSValue -> Implementation conversions
Sam Weinig
Reported 2024-05-24 13:28:31 PDT
Introduce a concrete result type for JSValue -> Implementation conversions. This is a precursor to supporting non-default initializable implementation types in a general way.
Attachments
Radar WebKit Bug Importer
Comment 1 2024-05-24 14:10:35 PDT
Sam Weinig
Comment 2 2024-05-24 14:11:21 PDT
EWS
Comment 3 2024-05-25 12:45:20 PDT
Committed 279321@main (9a160ff054ee): <https://commits.webkit.org/279321@main> Reviewed commits have been landed. Closing PR #29085 and removing active labels.
Fujii Hironori
Comment 4 2024-05-26 13:31:33 PDT
Regressed: Bug 274732 – REGRESSION(279321@main): js/dom/missing-exception-check-in-convertVariadicArguments.html is crashing : Unchecked exception detected at JSC::VM::verifyExceptionCheckNeedIsSatisfied : ASSERTION FAILED: !m_needExceptionCheck
Diego Pino
Comment 5 2024-05-27 04:44:45 PDT
Build bot 'WPE-Linux-64-bit-Release-Ubuntu-2204-Build' is failing with the following build error after this patch: https://build.webkit.org/#/builders/1060/builds/444 ``` /home/buildbot/worker/WPE-Linux-64-bit-Release-Ubuntu-2204-Build/build/Source/WebCore/bindings/js/JSDOMConvertResult.h:119:60: error: could not convert ‘T{other.releaseReturnValue()}’ from ‘T’ to ‘WebCore::Detail::ConversionResultStorage<T&>::ReturnType’ 119 | return ReturnType { other.releaseReturnValue() }; | ^ | | | T ```
Diego Pino
Comment 6 2024-05-27 04:45:45 PDT
EWS
Comment 7 2024-05-27 07:24:20 PDT
Committed 279350@main (cd96a999407c): <https://commits.webkit.org/279350@main> Reviewed commits have been landed. Closing PR #29147 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.