Bug 27466 - Search boxes should fallback when the RenderTheme doesn't deal with them
Summary: Search boxes should fallback when the RenderTheme doesn't deal with them
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-20 15:55 PDT by Adam Langley
Modified: 2009-07-20 20:06 PDT (History)
0 users

See Also:


Attachments
patch (1.44 KB, patch)
2009-07-20 15:58 PDT, Adam Langley
eric: review-
Details | Formatted Diff | Diff
patch (1.77 KB, patch)
2009-07-20 19:57 PDT, Adam Langley
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Langley 2009-07-20 15:55:04 PDT
<input type="search"> is very much like a text entry except that, currently, if the RenderTheme doesn't deal with it, nothing is rendered. With this patch, the default CSS border is rendered if the RenderTheme requests it.
Comment 1 Adam Langley 2009-07-20 15:58:00 PDT
Created attachment 33118 [details]
patch
Comment 2 Eric Seidel (no email) 2009-07-20 19:28:30 PDT
Comment on attachment 33118 [details]
patch

Change looks fine.  Fix the fallthrough issue and re-post. :)
Comment 3 Adam Langley 2009-07-20 19:57:05 PDT
Created attachment 33139 [details]
patch
Comment 4 Eric Seidel (no email) 2009-07-20 19:59:44 PDT
Comment on attachment 33139 [details]
patch

Your changelog is unclear.

This is already covered by many layout tests.  It's just that chromium layout test results are not stored in the webkit tree.

Your comment currently sounds like you're adding new tests, but only to the chromium tree, which makes no sense. ;)

please adjust the commnet when landing.