Bug 274649 - [WPE][run-benchmark] The browser is not terminated when there is a timeout
Summary: [WPE][run-benchmark] The browser is not terminated when there is a timeout
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-24 06:52 PDT by Carlos Alberto Lopez Perez
Modified: 2024-05-27 06:27 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2024-05-24 06:52:46 PDT 
I have been observing lot of timeouts on the benchmarks run at https://build.webkit.org/#/builders/WPE-Linux-RPi4-64bits-Mesa-Release-Perf-Tests

The problem is caused  because when the benchmark timeouts the runner exits without killing the browser, which means that the browser stays on the screen.
So on the next run for the next benchmark the new browser invoked can't run (hangs) because of the specific configuration of the boards (WPE with DRM plugin; only one browser allowed at a time)

We need to ensure to terminate old browsers when the runner ends.
Comment 1 Carlos Alberto Lopez Perez 2024-05-24 07:16:21 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/29051
Comment 2 EWS 2024-05-27 06:26:07 PDT 
Committed 279349@main (77548fd93ab4): <https://commits.webkit.org/279349@main>

Reviewed commits have been landed. Closing PR #29051 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-05-27 06:27:14 PDT 
<rdar://problem/128791676>