Bug 274601 - [PlayStation] Fix build break after 279061@main
Summary: [PlayStation] Fix build break after 279061@main
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 274615 274616
Blocks:
  Show dependency tree / graph
 
Reported: 2024-05-23 11:12 PDT by Jigen Zhou
Modified: 2024-05-23 15:11 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jigen Zhou 2024-05-23 11:12:05 PDT 
03:44:29  D:/merging-webkit/build-job/Source/WTF\wtf/text/UniquedStringImpl.h:34:7: error: 'suppress' attribute only applies to variables and statements
03:44:29     34 | class SUPPRESS_REFCOUNTED_WITHOUT_VIRTUAL_DESTRUCTOR UniquedStringImpl : public StringImpl {
03:44:29        |       ^
03:44:29  D:/merging-webkit/build-job/Source/WTF\wtf/Compiler.h:512:5: note: expanded from macro 'SUPPRESS_REFCOUNTED_WITHOUT_VIRTUAL_DESTRUCTOR'
03:44:29    512 |     IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE("webkit.RefCntblBaseVirtualDtor")
03:44:29        |     ^
03:44:29  D:/merging-webkit/build-job/Source/WTF\wtf/Compiler.h:470:73: note: expanded from macro 'IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE'
03:44:29    470 | #define IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE(warning, ...) [[clang::suppress]]
03:44:29        |                                                                         ^
Comment 1 Fujii Hironori 2024-05-23 13:33:47 PDT 
Did bug#274484 fix it?
Comment 2 EWS 2024-05-23 14:14:17 PDT 
Committed 279233@main (1d67aa3bb515): <https://commits.webkit.org/279233@main>

Reviewed commits have been landed. Closing PR #28998 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-05-23 14:15:24 PDT 
<rdar://problem/128636573>
Comment 4 WebKit Commit Bot 2024-05-23 14:31:58 PDT 
Re-opened since this is blocked by bug 274616
Comment 5 Ryosuke Niwa 2024-05-23 14:32:39 PDT 
This fix is redundant. It was already fixed in 279094@main.
Comment 6 Jigen Zhou 2024-05-23 15:11:22 PDT 
(In reply to Ryosuke Niwa from comment #5)
> This fix is redundant. It was already fixed in 279094@main.
Sorry, I didn't notice the fix.