RESOLVED CONFIGURATION CHANGED 274601
[PlayStation] Fix build break after 279061@main 
https://bugs.webkit.org/show_bug.cgi?id=274601
Summary [PlayStation] Fix build break after 279061@main
Jigen Zhou
Reported 2024-05-23 11:12:05 PDT
03:44:29 D:/merging-webkit/build-job/Source/WTF\wtf/text/UniquedStringImpl.h:34:7: error: 'suppress' attribute only applies to variables and statements 03:44:29 34 | class SUPPRESS_REFCOUNTED_WITHOUT_VIRTUAL_DESTRUCTOR UniquedStringImpl : public StringImpl { 03:44:29 | ^ 03:44:29 D:/merging-webkit/build-job/Source/WTF\wtf/Compiler.h:512:5: note: expanded from macro 'SUPPRESS_REFCOUNTED_WITHOUT_VIRTUAL_DESTRUCTOR' 03:44:29 512 | IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE("webkit.RefCntblBaseVirtualDtor") 03:44:29 | ^ 03:44:29 D:/merging-webkit/build-job/Source/WTF\wtf/Compiler.h:470:73: note: expanded from macro 'IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE' 03:44:29 470 | #define IGNORE_CLANG_STATIC_ANALYZER_WARNINGS_ATTRIBUTE(warning, ...) [[clang::suppress]] 03:44:29 | ^
Attachments
Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2024-05-23 13:33:47 PDT
Did bug#274484 fix it?
EWS
Comment 2 2024-05-23 14:14:17 PDT
Committed 279233@main (1d67aa3bb515): <https://commits.webkit.org/279233@main> Reviewed commits have been landed. Closing PR #28998 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-05-23 14:15:24 PDT
<rdar://problem/128636573>
WebKit Commit Bot
Comment 4 2024-05-23 14:31:58 PDT
Re-opened since this is blocked by bug 274616
Ryosuke Niwa
Comment 5 2024-05-23 14:32:39 PDT
This fix is redundant. It was already fixed in 279094@main.
Jigen Zhou
Comment 6 2024-05-23 15:11:22 PDT
(In reply to Ryosuke Niwa from comment #5) > This fix is redundant. It was already fixed in 279094@main. Sorry, I didn't notice the fix.
Note You need to log in before you can comment on or make changes to this bug.