Bug 27460 - WebCore/platform/FileSystem.h needs to include wtf/Platform.h before using the PLATFORM macro
Summary: WebCore/platform/FileSystem.h needs to include wtf/Platform.h before using th...
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-20 13:07 PDT by Dumitru Daniliuc
Modified: 2009-07-20 15:50 PDT (History)
0 users

See Also:

Attachments
patch (1.01 KB, patch)
2009-07-20 13:20 PDT, Dumitru Daniliuc 		fishd: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dumitru Daniliuc 2009-07-20 13:07:14 PDT 
FileSystem.h includes wtf/Platform.h after using the PLATFORM macro. Depending on where FileSystem.h is included, PLATFORM might or might not be defined. In general though, wtf/Platform.h should be included at the very top of FileSystem.h.
Comment 1 Dumitru Daniliuc 2009-07-20 13:20:22 PDT 
Created attachment 33101 [details]
patch
Comment 2 Darin Fisher (:fishd, Google) 2009-07-20 13:29:46 PDT 
Comment on attachment 33101 [details]
patch

This is not correct.  The implication of this change is that some .cpp file is not including config.h.
Comment 3 Dumitru Daniliuc 2009-07-20 15:50:33 PDT 
The problem is on the Chromium side.