Bug 274534 - [Xcode] WK_WORKSPACE_DIR build setting computed incorrectly when WebKit is checked out in a directory named "Source"
Summary: [Xcode] WK_WORKSPACE_DIR build setting computed incorrectly when WebKit is ch...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Elliott Williams
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-22 10:29 PDT by Elliott Williams
Modified: 2024-05-23 12:55 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Elliott Williams 2024-05-22 10:29:05 PDT 
In WebKitProjectPaths.xcconfig, WK_WORKSPACE_DIR is computed by walking up the file hierarchy and looking for a "Source" or "Tools" directory to indicate the root directory of the repo. But it doesn't terminate when it finds a match.
Comment 1 Radar WebKit Bug Importer 2024-05-22 10:29:21 PDT 
<rdar://problem/128549939>
Comment 2 EWS 2024-05-23 12:55:47 PDT 
Committed 279224@main (d67f50b1bb68): <https://commits.webkit.org/279224@main>

Reviewed commits have been landed. Closing PR #28926 and removing active labels.