RESOLVED FIXED 27447
WebInspector: Accept autocomplete on 'End' key pressed. 
https://bugs.webkit.org/show_bug.cgi?id=27447
Summary WebInspector: Accept autocomplete on 'End' key pressed.
Pavel Feldman
Reported 2009-07-20 08:36:28 PDT
Currently only 'Right' leads to autocomplete accept. Should be both 'Right' and 'End'.
Attachments
зфеср (1015 bytes, patch)
2009-07-20 08:55 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
patch (1.04 KB, patch)
2009-07-21 02:13 PDT, Pavel Feldman 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2009-07-20 08:55:50 PDT
Created attachment 33087 [details] зфеср
Eric Seidel (no email)
Comment 2 2009-07-20 14:47:47 PDT
In XCode "end" cancels autocomplete. What autocomplete are you basing this functionality off of? MS Word?
Pavel Feldman
Comment 3 2009-07-21 02:01:01 PDT
(In reply to comment #2) > In XCode "end" cancels autocomplete. What autocomplete are you basing this > functionality off of? MS Word? On non-Mac OS-based systems (Linux, Windows), "End" is moving cursor to the end of the edit field. It sounds much more intuitive to use "End" for auto-complete accept rather than "Right" arrow on these platforms. I could make this action platform-specific, but then decided to keep it simple. On a more general topic, non-popup-based autocomplete is pretty unique to XCode and I don't think many web developers find it useful. (much more are familiar with Eclipse and Visual Studio). So I am thinking of filing a bug to support popup-based autocomplete.
Pavel Feldman
Comment 4 2009-07-21 02:13:41 PDT
Created attachment 33163 [details] patch
Timothy Hatcher
Comment 5 2009-07-28 20:35:40 PDT
Comment on attachment 33163 [details] patch Sometimes space accepts completions too, but I think that isn't as comon. (I never used End before.)
Pavel Feldman
Comment 6 2009-07-28 21:41:07 PDT
Committed r46515 M WebCore/ChangeLog M WebCore/inspector/front-end/TextPrompt.js r46515 = 3a4dd73bf7f0b4ef5f4148170c0a1e7e6330f94d (trunk)
Note You need to log in before you can comment on or make changes to this bug.