Bug 274432 - Logger should have a virtual destructor
Summary: Logger should have a virtual destructor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-20 19:27 PDT by Ryosuke Niwa
Modified: 2024-05-20 21:29 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2024-05-20 19:27:39 PDT 
Since AggregateLogger subclasses Logger and have a non-trivial destructor,
Logger should have a virtue destructor.
Comment 1 Ryosuke Niwa 2024-05-20 19:30:15 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28820
Comment 2 EWS 2024-05-20 21:28:40 PDT 
Committed 279033@main (7d4bbc7f02e0): <https://commits.webkit.org/279033@main>

Reviewed commits have been landed. Closing PR #28820 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-05-20 21:29:15 PDT 
<rdar://problem/128442762>